Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet only label #1628

Merged
4 commits merged into from
Feb 25, 2022
Merged

Add wallet only label #1628

4 commits merged into from
Feb 25, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Feb 22, 2022

Closes #1343

Tag has been added in enable modal
image

Disabled swap button with tooltip when coin is wallet only
image

Do we want this tagging alongside the ticker on portfolio? Or in wallet header section? Not really sure where to slot it in.

@smk762 smk762 requested review from a user and tonymorony February 22, 2022 22:54
@tonymorony tonymorony self-requested a review February 23, 2022 09:53
@tonymorony
Copy link

tonymorony commented Feb 23, 2022

buttons looks different now:

image

Copy link

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@smk762
Copy link
Collaborator Author

smk762 commented Feb 23, 2022

^^

fixed, thanks.

buttons.mp4

@smk762 smk762 requested a review from tonymorony February 23, 2022 16:05
Copy link

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, lgtm now

@ghost ghost merged commit 7603a17 into dev Feb 25, 2022
@smk762 smk762 deleted the wallet_only branch April 2, 2022 12:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Add "Wallet only" label for wallet only assets
2 participants